Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only set err.status on statusCode >= 200 #677

Merged
merged 1 commit into from
May 14, 2024
Merged

fix: only set err.status on statusCode >= 200 #677

merged 1 commit into from
May 14, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 14, 2024 •
edited by coderabbitai bot
Loading

nodejs.AssertionError: invalid status code: -1

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling to ensure the HTTP status code is valid and within the correct range.

@fengmk2 fengmk2 added the bug Something isn't working label May 14, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 14, 2024 •
edited
Loading

Walkthrough

The primary change involves updating the ErrorHandler middleware in TypeScript to ensure that the HTTP status code is valid. The status is now assigned based on the condition that it is a number and greater than or equal to 200, improving the robustness of error handling.

Changes

File Change Summary
app/.../middleware/ErrorHandler.ts Updated HTTP status assignment logic to validate that err.status is a number and >= 200

Poem

In code, we weave a careful thread,
To catch the errors we most dread.
A status true, a number sound,
Ensures our app stays safe and sound.
With each small change, we build anew,
A world where bugs are far and few. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
app/port/middleware/ErrorHandler.ts (1)

34-34: The logic to ensure ctx.status is only set when err.status is a valid HTTP status code is correctly implemented.

Consider adding a comment explaining why the status code check is necessary, as this could enhance maintainability and understanding for future developers.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between dbf5b52 and 0403ef6.
Files selected for processing (1)
  • app/port/middleware/ErrorHandler.ts (1 hunks)

@fengmk2 fengmk2 merged commit 668eed2 into master May 14, 2024
11 checks passed
@fengmk2 fengmk2 deleted the fix-ctx-status branch May 14, 2024 02:28
fengmk2 pushed a commit that referenced this pull request May 14, 2024
@semantic-release-bot
Release 3.56.1
cdca770 
[skip ci]

## [3.56.1](v3.56.0...v3.56.1) (2024-05-14)

### Bug Fixes

* only set err.status on statusCode >= 200 ([#677](#677)) ([668eed2](668eed2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fengmk2